Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Wiring up the UI to the events #776

Merged
10 commits merged into from
Apr 9, 2021
Merged

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Apr 6, 2021

Summary of the Pull Request

  • The UI now receives the telemetry events
  • A new section for the coverage has been added
  • All synced dir are now monitored by the UI
  • Gracefully exit from the UI

depends on #663

@chkeita
Copy link
Contributor Author

chkeita commented Apr 6, 2021

v1
image

v2
image

@chkeita chkeita force-pushed the chkeita/local_run_ui2 branch from 9aabc86 to f535525 Compare April 6, 2021 21:54
Added new section for the coverage in the UI
Added event broadcast in the the telemtry lib
Gracefully exit from the UI
@chkeita chkeita force-pushed the chkeita/local_run_ui2 branch from f535525 to 9ec4f74 Compare April 6, 2021 21:59
@chkeita chkeita marked this pull request as ready for review April 6, 2021 22:12
@bmc-msft
Copy link
Contributor

bmc-msft commented Apr 6, 2021

When I run libfuzzer-fuzz, I don't see inputs as a monitored container.

@bmc-msft
Copy link
Contributor

bmc-msft commented Apr 6, 2021

There is a ~30s delay from quitting the agent with q and the atexit code firing.

@bmc-msft
Copy link
Contributor

bmc-msft commented Apr 6, 2021

If I run a libfuzzer task with files in the inputs directory, I see all of the files listed show up as a "new_coverage" event. I would not expect these to be reported as new coverage

@ghost
Copy link

ghost commented Apr 9, 2021

Hello @bmc-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 4086e76 into microsoft:main Apr 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 9, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants